molanis.com/forum - Tools for MetaTrader : The place to ask about the best expert advisor builder, expert advisor downloads, and expert advisor programming

I created an EA by strategy builder as attached. The EA is supposed to close positions created by another EA. The conditions for closing positions are as below. But the EA does not close open positions as design. I would appreciate any help.

Conditions for closing buy positions:
-Either line of customized indicator touch 97
Or,
-Both Lines of customized indicator, slow-stoch.mq4, cross over


Conditions for closing sell positions:
-Either line of customized indicator touch 3
Or,
-Both Lines of customized indicator, slow-stoch.mq4, cross over

If you want to close conditions created by another ea you need to use the same magic number(s) for both eas.
Expert advisors for metatrader use an id called the magic number, we use one for long positions and one for short positions. You can see then in mt4 unde the ea inputs.
By default eas created with molanis strategy builder close positions that have the same magic number, and positions with magic number = 0 (0 means manually opened)
Build an ea with a simple condition to test that closing work fine and then revisit your posted ea.